From cba5ecbbb4fddbd3a6a28e618ea62a72a140c4e2 Mon Sep 17 00:00:00 2001 From: Humdinger Date: Thu, 08 Dec 2022 14:37:17 +0100 Subject: [PATCH] Thumbnail: fix off-by-one of Height/Width attribute Fixes #18128 Change-Id: I3abe72552657517acece101a1653b2f013b4f23f Reviewed-on: https://review.haiku-os.org/c/haiku/+/5881 Tested-by: Commit checker robot Reviewed-by: waddlesplash (cherry picked from commit d3811d00367caaabe90e0c20704b04f51aebd75d) Reviewed-on: https://review.haiku-os.org/c/haiku/+/5855 --- src/kits/tracker/Thumbnails.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/kits/tracker/Thumbnails.cpp b/src/kits/tracker/Thumbnails.cpp index 3e7d717..b246bce 100644 --- a/src/kits/tracker/Thumbnails.cpp +++ b/src/kits/tracker/Thumbnails.cpp @@ -200,12 +200,12 @@ // write values to attributes bool thumbnailWritten = false; - const int32 width = image->Bounds().IntegerWidth(); + const int32 width = image->Bounds().IntegerWidth() + 1; const size_t written = fFile->WriteAttr("Media:Width", B_INT32_TYPE, 0, &width, sizeof(int32)); if (written == sizeof(int32)) { // first attribute succeeded, write the rest - const int32 height = image->Bounds().IntegerHeight(); + const int32 height = image->Bounds().IntegerHeight() + 1; fFile->WriteAttr("Media:Height", B_INT32_TYPE, 0, &height, sizeof(int32)); // convert image into a 128x128 WebP image and stash it -- gitore 0.2.3